-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron stream plugin fix #9256
Electron stream plugin fix #9256
Conversation
A new Pull Request was created by @shervin86 for CMSSW_7_5_X. Electron stream plugin fix It involves the following packages: Calibration/EcalAlCaRecoProducers @cmsbuild, @mmusich, @diguida, @cerminar, @nclopezo can you please review it and eventually sign? Thanks. |
-1 >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-23-2300/src/Calibration/EcalAlCaRecoProducers/plugins/AlCaECALRecHitReducer.cc >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-23-2300/src/Calibration/EcalAlCaRecoProducers/plugins/AlCaElectronTracksReducer.cc >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-23-2300/src/Calibration/EcalAlCaRecoProducers/plugins/PUDumper.cc >> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-23-2300/src/Calibration/EcalAlCaRecoProducers/plugins/SelectedElectronFEDListProducer.cc In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-23-2300/src/Calibration/EcalAlCaRecoProducers/plugins/SelectedElectronFEDListProducer.cc:1:0: /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_7_5_X_2015-05-23-2300/poison/Calibration/EcalAlCaRecoProducers/interface/SelectedElectronFEDListProducer.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE. ^ >> Building shared library tmp/slc6_amd64_gcc491/src/FWCore/Version/src/FWCoreVersion/libFWCoreVersion.so Copying tmp/slc6_amd64_gcc491/src/FWCore/Version/src/FWCoreVersion/libFWCoreVersion.so to productstore area: Leaving library rule at FWCore/Version you can see the results of the tests here: |
I have fixed it. I don't know why when I had compiled with scram I got no errors... |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
@davidlange6 @Degano @smuzaffar can this be merged? |
In order to have the #9085 integrated, can we merge this, when possible? |
+1 |
This fixes the absence of the SelectedElectronFEDListProducer after the merge of PR #8306
The .cc and .h of the plugin has been moved to the plugin directory and now compiles.
Now the plugin is correctly restored as in any 75X pre release before #8306.
To avoid conflicts I have already merged with #9112.
This can PR can be merged after that or at the place of.
@davidlange6 @rgerosa @amassiro